Skip to content

Add SVG support #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

generikjano
Copy link

No description provided.

@jimlambie
Copy link
Contributor

@generikjano thanks for the pull request!

Using the image handler for this will currently fail if any image manipulation parameters are applied to the request URL. For example /image.svg?q=80 will result in a 400 error because the underlying image processor doesn't handle SVG.

I believe in order to make this work in a more generic way, CDN should throw away any supplied parameters if the image type is SVG.

@generikjano
Copy link
Author

@generikjano thanks for the pull request!

Using the image handler for this will currently fail if any image manipulation parameters are applied to the request URL. For example /image.svg?q=80 will result in a 400 error because the underlying image processor doesn't handle SVG.

I believe in order to make this work in a more generic way, CDN should throw away any supplied parameters if the image type is SVG.

Hello @jimlambie,

Thanks for the answer.
Agree, I will work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants