-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-pipes-rust] - Inital integration with the pipes test suite #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be more appropriate to disable all tests in pipes.toml
instead (so that they are skipped) rather than having no-op tests.
- It would more explicitly communicate that there are no tests written yet.
- It would make it easier to incrementally enable them one by one.
On a side note, the tests CLI args are not stabilized yet, we will be standardizing them next week with @GingerYouth for Java
That's a good point! I set all (skippable) tests to be skipped now.
That is good to know. I'll probably keep this PR in draft for a bit longer to work out how to deal with the |
I think it's ok to start working on the tests. We will probably remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just a small naming comment
Summary & Motivation
This sets up the initial integration with the
dagster-pipes-tests
suite. Most of the tests are skipped right now, they can be enabled incrementally.The tests are run from a binary that is only included in the build if the optional
pipes-tests
feature is enabled. This keeps the main library slim.Contributes to #58
How I Tested These Changes
Changelog
Ensure that an entry has been created in
CHANGELOG.md
outlining additions, deletions, and/or modifications.See: keepachangelog.com