[dagster-pipes-rust] - Adds support for reporting custom messages #70
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marijncv
commented
Dec 23, 2024
|
|
||
| pub fn report_custom_message( | ||
| &mut self, | ||
| payload: Option<serde_json::Value>, |
There was a problem hiding this comment.
Maybe it makes sense to expect a Value instead of Option<Value> here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This enables support for reporting custom messages, following the public api of the python implementation here
It also enables the tests from the dagster-pipes-tests suite.
How I Tested These Changes
Added/enabled tests
Changelog
Ensure that an entry has been created in
CHANGELOG.mdoutlining additions, deletions, and/or modifications.See: keepachangelog.com