Skip to content

Commit

Permalink
Add dagster_internal_branch and dagster_oss_branch args to create-rc …
Browse files Browse the repository at this point in the history
…command

Summary:
Allows you to create an RC with a given instead of from pypi.

Test Plan: Run this locally
  • Loading branch information
gibsondan committed May 23, 2024
1 parent 7c2f65f commit 9c73075
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion scripts/release.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ def create_rc(
check_workdir: bool = True,
execute_tests: bool = True,
publish_docker_action: bool = True,
dagster_internal_branch: Optional[str] = DAGSTER_INTERNAL_BRANCH_OPTION,
dagster_oss_branch: Optional[str] = DAGSTER_OSS_BRANCH_OPTION,
):
if check_workdir:
ensure_clean_workdir()
Expand All @@ -168,7 +170,7 @@ def create_rc(
error(f"Invalid version tag {version_tag}")
sys.exit(1)

update_dagster_cloud_pex(None, None)
update_dagster_cloud_pex(dagster_internal_branch, dagster_oss_branch)
if execute_tests:
run_tests()
build_docker_action(version_tag, publish_docker_action)
Expand Down

0 comments on commit 9c73075

Please sign in to comment.