Skip to content

Commit

Permalink
respond to review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
benpankow committed Jul 29, 2024
1 parent 00f93cb commit fb499d4
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions github/serverless/dagster-plus-deploy.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Serverless Deployment
name: Dagster Cloud Serverless Deployment
on:
push:
branches:
Expand All @@ -16,7 +16,7 @@ env:
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
ENABLE_FAST_DEPLOYS: 'true'
PYTHON_VERSION: '3.8'
DAGSTER_PROJECT_DIR: '.'
DAGSTER_CLOUD_YAML_PATH: '.'
DAGSTER_CLOUD_FILE: 'dagster_cloud.yaml'
DAGSTER_CLOUD_ORGANIZATION: ${{ secrets.DAGSTER_CLOUD_ORGANIZATION }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -42,14 +42,14 @@ jobs:
if: steps.prerun.outputs.result != 'skip'
uses: dagster-io/dagster-cloud-action/actions/utils/[email protected]
with:
command: "ci check --project-dir ${{ env.DAGSTER_PROJECT_DIR }} --dagster-cloud-yaml-path ${{ env.DAGSTER_CLOUD_FILE }}"
command: "ci check --project-dir ${{ env.DAGSTER_CLOUD_YAML_PATH }} --dagster-cloud-yaml-path ${{ env.DAGSTER_CLOUD_FILE }}"

# Parse dagster_cloud.yaml, detect if this is branch deployment and initialize the build session
- name: Initialize build session
id: ci-init
uses: dagster-io/dagster-cloud-action/actions/utils/[email protected]
with:
project_dir: ${{ env.DAGSTER_PROJECT_DIR }}
project_dir: ${{ env.DAGSTER_CLOUD_YAML_PATH }}
dagster_cloud_yaml_path: ${{ env.DAGSTER_CLOUD_FILE }}
# The full deployment name. If this run is for a PR, this value is ignored and a branch
# deployment is used.
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
if: steps.prerun.outputs.result != 'skip'
uses: dagster-io/dagster-cloud-action/actions/utils/[email protected]
with:
command: "ci notify --project-dir=${{ env.DAGSTER_PROJECT_DIR }}"
command: "ci notify --project-dir=${{ env.DAGSTER_CLOUD_YAML_PATH }}"

# Generate a summary that shows up on the Workflow Summary page
- name: Generate a summary
Expand Down

0 comments on commit fb499d4

Please sign in to comment.