Allow a full deployment not called 'prod' for pex deploys #155
Conversation
|
Your pull request is automatically being deployed to Dagster Cloud.
|
|
How suspicious is the test failure here? |
|
This is different from how you set it for hybrid deploys right? Could we make both use this env var? |
|
ah good points re consistency. I'll make this self consistent with how we do serverless docker deploys using the input field instead. eventually i want to replace the serverless workflow entirely with the new workflows we use for hybrid (https://github.com/dagster-io/dagster-cloud-hybrid-quickstart/) but haven't gotten around to testing, releasing and documenting that. |
|
@gibsondan - made this consistent with docker deploys using a new The test failures have been happening for a while and we haven't gotten around to identifying or fixing them yet. |
| deployment_name = None | ||
| # INPUT_DEPLOYMENT is to the `deployment:` input value in action.yml | ||
| deployment_name = os.getenv("INPUT_DEPLOYMENT", "prod") | ||
| print(f"Deploying to a full deployment: {deployment_name}", flush=True) |
There was a problem hiding this comment.
"Deploying to a deployment" reads a bit oddly
The default deployment name can be overridden using the
deployment:input to the action. EgTest Plan
Rename a deployment to something other than
prodPoint the
build_deploy_python_executableaction indeploy.ymlto this branch and add thedeployment:inputVerify that the workflow deployment works
Rename deployment back to
prodVerify that workflow deployment fails
Remove
deployment:inputVerify that the workflow deployment works again
Ran all above steps in a test org successfully.