always use an agent heartbeat timeout of 600 in CI/CD #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The current logic breaks down if you deploy to serverless and then redeploy with a code change in the middle of the initial deploy, which seems more likely and worth designing around than the (hopefully unlikely) case of the serverless agent going down and needing to wait a few more minutes to find out. Test Plan:Point a pex deploy at this image hash
|
Your pull request is automatically being deployed to Dagster Cloud.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The current logic breaks down if you deploy to serverless and then redeploy with a code change in the middle of the initial deploy, which seems more likely and worth designing around than the (hopefully unlikely) case of the serverless agent going down and needing to wait a few more minutes to find out.
Test Plan:Point a pex deploy at this image hash