Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DbtProject support in serverless template #165

Merged

Conversation

alangenfeld
Copy link
Member

@alangenfeld alangenfeld commented Apr 8, 2024

Replace the dbt project preparation in the serverless github action templates with the new DbtProject based set-up.

Testing against https://github.com/alangenfeld/dagster-dbt-testing/pull/2/files

https://alex-02-08-2024.dagster.cloud/

@alangenfeld
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alangenfeld and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Apr 8, 2024

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud Apr 10, 2024 at 08:08 PM (UTC)

@alangenfeld alangenfeld force-pushed the al/04-08-dbtproject_support_in_serverless_template branch from ce76391 to 3292022 Compare April 8, 2024 20:06
Copy link
Contributor

@rexledesma rexledesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna send this back to your queue for now -- this depends on the changes to dagster-dbt project scaffold to use DbtProject. PR for that should be coming shortly.

cd ${{ env.ROOT_DIR }}/${{ env.DAGSTER_PROJECT_NAME }}
pip install . --upgrade --upgrade-strategy eager
dagster-dbt project prepare-for-deployment --file ${{ env.DAGSTER_PROJECT_NAME }}/project.py
# dagster-cloud ci dbt-project manage-state --file ${{ env.DAGSTER_PROJECT_NAME }}/project.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be dagster-cloud ci dagster-dbt project manage-state now.

Maybe add a comment on when to uncomment that line? And probably some documentation to add *dbt.get_defer_args() and state_path to DbtProject for this to work successfully

@alangenfeld alangenfeld force-pushed the al/04-08-dbtproject_support_in_serverless_template branch from 3292022 to 72b7aa6 Compare April 10, 2024 14:45
@alangenfeld alangenfeld requested a review from rexledesma April 10, 2024 14:47
Copy link
Contributor

@rexledesma rexledesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- might have to double check if we can merge this immediately, since this might affect the current NUX in prod?

@alangenfeld
Copy link
Member Author

ya will work through the sequencing with @shalabhc

@alangenfeld alangenfeld force-pushed the al/04-08-dbtproject_support_in_serverless_template branch 2 times, most recently from 6b69956 to 6fb3c4b Compare April 10, 2024 16:15
@alangenfeld alangenfeld force-pushed the al/04-08-dbtproject_support_in_serverless_template branch from 6fb3c4b to 3a7702a Compare April 10, 2024 20:05
@alangenfeld alangenfeld merged commit c7b073d into main Apr 11, 2024
7 of 9 checks passed
@alangenfeld alangenfeld deleted the al/04-08-dbtproject_support_in_serverless_template branch April 11, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants