-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DbtProject support in serverless template #165
DbtProject support in serverless template #165
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alangenfeld and the rest of your teammates on Graphite |
Your pull request is automatically being deployed to Dagster Cloud.
|
ce76391
to
3292022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna send this back to your queue for now -- this depends on the changes to dagster-dbt project scaffold
to use DbtProject
. PR for that should be coming shortly.
cd ${{ env.ROOT_DIR }}/${{ env.DAGSTER_PROJECT_NAME }} | ||
pip install . --upgrade --upgrade-strategy eager | ||
dagster-dbt project prepare-for-deployment --file ${{ env.DAGSTER_PROJECT_NAME }}/project.py | ||
# dagster-cloud ci dbt-project manage-state --file ${{ env.DAGSTER_PROJECT_NAME }}/project.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be dagster-cloud ci dagster-dbt project manage-state
now.
Maybe add a comment on when to uncomment that line? And probably some documentation to add *dbt.get_defer_args()
and state_path
to DbtProject
for this to work successfully
3292022
to
72b7aa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- might have to double check if we can merge this immediately, since this might affect the current NUX in prod?
ya will work through the sequencing with @shalabhc |
6b69956
to
6fb3c4b
Compare
6fb3c4b
to
3a7702a
Compare
Replace the dbt project preparation in the serverless github action templates with the new
DbtProject
based set-up.Testing against https://github.com/alangenfeld/dagster-dbt-testing/pull/2/files
https://alex-02-08-2024.dagster.cloud/