update contributing guide #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiedemaria
commented
Apr 11, 2024
| @@ -3,19 +3,22 @@ | |||
| ## Step 1. Log into docker ghcr.io | |||
|
|
|||
| See [authenticate to GHCR with a PAT](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry). | |||
| Your PAT will need `delete:packages`, `write:packages`, and`repo` permissions. | |||
There was a problem hiding this comment.
TODO - my PAT had these perms, may be able to do a smaller set
|
Your pull request is automatically being deployed to Dagster Cloud.
|
jamiedemaria
commented
Apr 11, 2024
| @@ -51,7 +54,10 @@ A script does this work: | |||
|
|
|||
| ``` | |||
|
|
|||
| This leaves uncommited changes in the working directory. | |||
| Note that `OLD_VERSION` may not be the latest tag printed in step 2. You can find the `OLD_VERSION` by looking | |||
There was a problem hiding this comment.
TODO - confirm if this is the best way to do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the contributing guide with some things I learned while going through this process