Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.head_ref in ci init if the event is a PR #170

Merged

Conversation

vicyap
Copy link
Contributor

@vicyap vicyap commented Apr 18, 2024

This PR changes the commit hash used by ci-init to use github.head_ref instead of github.sha.

github.sha on a PR event returns the merged commit sha of the default branch merged with the head commit of the PR's branch. This merge commit does not actually exist, so whenever a user clicks the git url on the Dagster Cloud Code Location page, it fails.

Example:
Screenshot 2024-04-18 at 14 07 47

Instead, I think the behavior should be to go to the head commit of the PR's branch.

@prha prha requested a review from shalabhc April 19, 2024 20:57
@vicyap
Copy link
Contributor Author

vicyap commented Apr 26, 2024

Hi @shalabhc - do you have any time to help me review this PR? We are currently using a fork with these changes, and it would help us if we can use the main repo so we don't have to maintain a fork.

@shalabhc shalabhc merged commit 44c959b into dagster-io:main May 6, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants