Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md with test examples #186

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Jul 15, 2024

To guide users on how to test new releases with both Serverless and Hybrid deployments.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maximearmstrong and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Jul 15, 2024

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud Jul 15, 2024 at 06:30 PM (UTC)

@maximearmstrong maximearmstrong self-assigned this Jul 15, 2024
@maximearmstrong maximearmstrong marked this pull request as ready for review July 15, 2024 16:41
@maximearmstrong maximearmstrong requested a review from shalabhc July 15, 2024 16:41
CONTRIBUTING.md Outdated
- GitHub: Deploy to a test organization in Dagster+ with both PEX and docker deployments.

Hybrid:
- GitHub: Create a new branch in the [Hooli repo](https://github.com/dagster-io/hooli-data-eng-pipelines) to update the release version. Push your changes and open a PR to test the deployment to Dagster+.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the tags in the github action to use then release version right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I've updated the sentence in 88081d6

@maximearmstrong maximearmstrong merged commit d8206eb into main Jul 15, 2024
7 of 9 checks passed
@maximearmstrong maximearmstrong deleted the maxime/update-contributing-md-with-tests branch July 15, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants