Add base_image support to the serverless_prod_deploy action #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Allows you to set build:base_image to vary the base image per code location. Would like to port this to the new "dagster-cloud ci" commands as well. Test Plan: Build a release branch and test a build with and without the base_image set, in both a dagster_cloud.yaml file and in the action itself.
|
Your pull request is automatically being deployed to Dagster Cloud.
|
shalabhc
reviewed
Aug 28, 2024
There was a problem hiding this comment.
This only affects the old workflow only for docker deploys and only in github. Adding a cicd specific feature to dagster_cloud.yaml doesn't seem right. For instance, there is no dagster-cloud cli command that will be affected by this parameter.
Should we just support this in the new workflow: https://github.com/dagster-io/dagster-cloud-action/blob/380badc507e760c569c6c1a3c914ddbf3b5cff81/github/serverless/dagster-plus-deploy.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allows you to set build:base_image to vary the base image per code location.
Would like to port this to the new "dagster-cloud ci" commands as well.
Test Plan:
Build a release branch and test a build with and without the base_image set, in both a dagster_cloud.yaml file and in the action itself.