Make deps.pex cache repo scoped, so PRs and main commits share deps.pex #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means the first PR action will rebuild the deps, however all subsequent PRs will be able to reuse the deps. If a PR changes deps then it will also get cached. Previous changing deps in a PR would rebuild the deps on each deploy.
|
Your pull request is automatically being deployed to Dagster Cloud.
|
shalabhc
changed the title
shalabhc
changed the title
gibsondan
approved these changes
Sep 8, 2024
Currently there is no way to manually clear the cache but it's possible using the env var in the old github workflow or directly modifying the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently PRs can only reuse deps.pex if PRs do not change the dependencies. When dependencies are changed within a PR, the deps.pex is built every time. This is an optimization to let PRs build new deps.pex only once and then reuse it.