Build dagster-cloud-action PEX for more platforms #200
+28
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request is automatically being deployed to Dagster Cloud.
|
gibsondan
force-pushed
the
buildmorepex
branch
3 times, most recently
from
388dd18 to
8f422f4
Compare
gibsondan
commented
Oct 2, 2024
gibsondan
force-pushed
the
buildmorepex
branch
from
8f422f4 to
415ec20
Compare
shalabhc
reviewed
Oct 2, 2024
| @@ -44,7 +44,7 @@ The point version is the next unused `v0.1.*` version, eg `v0.1.22` above. Creat | |||
|
|
|||
| ## Step 3. Build and deploy a new docker-cloud-action image, a new dagster.cloud.pex and update code references to docker | |||
|
|
|||
| A script does this work. **Note**: a virtual environment using Python3.8 is required to run the script. | |||
| A script does this work. **Note**: a virtual environment using Python3.11 is required to run the script. | |||
There was a problem hiding this comment.
why 3.11?
shouldn't we just pick one of the 3 defaults below?
maybe 310 because that's the default on internal?
There was a problem hiding this comment.
I did 3.11 because that's our default for development in general and because I changed a test case to depend on it
(3.10 is not the default on internal, 3.11 is)
shalabhc
reviewed
Oct 2, 2024
|
answering my own question - tox an internal use 3.11 by default so more likely to have that venv locally. |
shalabhc
approved these changes
Oct 2, 2024
gibsondan
force-pushed
the
buildmorepex
branch
4 times, most recently
from
8842762 to
13257d6
Compare
Summary: Make our dagster-cloud-cli work on github action runners that have python versions other than 3.8 installed.
gibsondan
force-pushed
the
buildmorepex
branch
from
13257d6 to
3318101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Make our dagster-cloud-cli work on github action runners that have python versions other than 3.8 installed.