Add arm64 platform support to dagster-cloud.pex, do the build inside a manylinux builder image #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request is automatically being deployed to Dagster Cloud.
|
gibsondan
commented
Oct 31, 2024
Comment on lines
-126
to
-127
| "--platform=macosx_12_0_x86_64-cp-311-cp311", | ||
| "--platform=macosx_12_0_arm64-cp-311-cp311", |
There was a problem hiding this comment.
i had to take these out to keep us below 100MB :/ is there a reason to keep them other than passing the local tests? I wouldn't expect anybody to actually be running this pex in a mac OS context since it's for github actions
There was a problem hiding this comment.
(well, they do have macOS github runners, but it would be very surprising if people were using them for this purpose)
There was a problem hiding this comment.
updated the PR to run the tests in docker images
There was a problem hiding this comment.
is there a reason to keep them other than passing the local tests?
no other reason. i'm ok with removing.
…a manylinux builder image Summary: Add an arm64 platform to the dagster-cloud.pex - it no longer builds locally, so do it in Docker now. Test Plan; Make a v0.1.48 release
gibsondan
force-pushed
the
onemoreplatform
branch
2 times, most recently
from
f3ac6ab to
eb73364
Compare
gibsondan
force-pushed
the
onemoreplatform
branch
from
eb73364 to
3f03263
Compare
gibsondan
added a commit
that referenced
this pull request
Oct 31, 2024
Summary: I believe after the test changes in #206 to no longer run the tests locally, it is safe (and more correct) to use this insteda of expecting python to be available at a particular path.
shalabhc
approved these changes
Nov 12, 2024
gibsondan
added a commit
that referenced
this pull request
Nov 12, 2024
Summary: I believe after the test changes in #206 to no longer run the tests locally, it is safe (and more correct) to use this insteda of expecting python to be available at a particular path.
gibsondan
added a commit
that referenced
this pull request
Nov 12, 2024
Summary: I believe after the test changes in #206 to no longer run the tests locally, it is safe (and more correct) to use this insteda of expecting python to be available at a particular path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add an arm64 platform to the dagster-cloud.pex - it no longer builds locally, so do it in Docker now.
Test Plan;
Make a v0.1.48 release