Merge pull request #9 from dagster-io/benpankow/new-git-metadata

Include git metadata in code locations by default
dagster-io · Jan 27, 2022 · 30cfca6 · 30cfca6
2 parents 34dd15d + 92d066a
commit 30cfca6
Show file tree

Hide file tree

Showing 6 changed files with 15,791 additions and 16,406 deletions.
diff --git a/deploy/action.yml b/deploy/action.yml
@@ -27,9 +27,6 @@ inputs:
     required: false
     default: true
 
-  experimental-git-data:
-    required: false
-    default: false
 runs:
   using: 'node12'
   main: '../dist/deploy/index.js'
diff --git a/dist/deploy/index.js b/dist/deploy/index.js
diff --git a/dist/deploy/index.js.map b/dist/deploy/index.js.map
diff --git a/dist/preview/index.js b/dist/preview/index.js
diff --git a/dist/preview/index.js.map b/dist/preview/index.js.map
diff --git a/src/deploy-action.js b/src/deploy-action.js
@@ -49,9 +49,7 @@ async function run() {
           );
         }
 
-        // Optionally include some experimental git data in the location metadata
-        // used for some rich linking UI
-        const includeGitData = core.getBooleanInput("experimental-git-data");
+        // Git metadata, used for rich linkbacks
         const sha = github.context.sha;
         const shortSha = sha.substr(0, 6);
         const url =
@@ -67,8 +65,8 @@ async function run() {
           workingDirectory: workingDirectory,
           executablePath: executablePath,
           attribute: attribute,
-          sha: includeGitData ? sha : undefined,
-          url: includeGitData ? url : undefined,
+          commitHash: sha,
+          url: url,
         };
 
         const result = await client.updateLocation(locationData);