Move Definitions to definitions.py (#31)

pyproject.toml

@@ -3,4 +3,5 @@ requires = ["setuptools"]
 build-backend = "setuptools.build_meta"
 
 [tool.dagster]
-module_name = "quickstart_etl"
+module_name = "quickstart_etl.definitions"
+code_location_name = "quickstart_etl"

quickstart_etl/__init__.py

@@ -1,16 +0,0 @@
-from dagster import (
-    Definitions,
-    ScheduleDefinition,
-    define_asset_job,
-    load_assets_from_package_module,
-)
-
-from . import assets
-
-daily_refresh_schedule = ScheduleDefinition(
-    job=define_asset_job(name="all_assets_job"), cron_schedule="0 0 * * *"
-)
-
-defs = Definitions(
-    assets=load_assets_from_package_module(assets), schedules=[daily_refresh_schedule]
-)

quickstart_etl/definitions.py

@@ -0,0 +1,16 @@
+from dagster import (
+    Definitions,
+    ScheduleDefinition,
+    define_asset_job,
+    load_assets_from_package_module,
+)
+
+from . import assets
+
+daily_refresh_schedule = ScheduleDefinition(
+    job=define_asset_job(name="all_assets_job"), cron_schedule="0 0 * * *"
+)
+
+defs = Definitions(
+    assets=load_assets_from_package_module(assets), schedules=[daily_refresh_schedule]
+)

quickstart_etl_tests/test_defs.py

@@ -1,4 +1,4 @@
-from quickstart_etl import defs
+from quickstart_etl.definitions import defs
 
 
 def test_def_can_load():

workspace.yaml

@@ -1,3 +1,3 @@
 load_from:
-  - python_package: quickstart_etl
+  - python_package: quickstart_etl.definitions