Skip to content

Commit

Permalink
pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jamiedemaria committed Aug 28, 2024
1 parent 10c981c commit 0fa09ef
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/docs-beta/docs/guides/deployment/kubernetes.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ To follow the steps in this guide, you'll need:

</details>

## Step 1: Get your Dagster project ready to deploy
## Step 1: Prepare your Dagster project
You will need to add a `workspace.yaml` file to your Dagster project to be ready to deploy with Kubernetes. If you are using the [example project](/todo), you will already have this file.

The `workspace.yaml` file tells Dagster where to find the `Definitions` object in your project. This file should be at the LOCATION of your project.
Expand Down
2 changes: 1 addition & 1 deletion examples/deploy_k8s_beta/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
This project is to be used with the [Deploy to Kubernetes](/todo) guide.

The Dagster project is found in `iris_analysis` and contains a single file `__init__.py`. This file defines an asset `iris_dataset_size` that fetches a dataset about irises and logs the number of rows in the dataset. A `Definitions` object is defined that will allow Dagster to load the `iris_dataset_size` asset.
The Dagster project is found in `iris_analysis` and contains a single file `definitions.py`. This file defines an asset `iris_dataset_size` that fetches a dataset about irises and logs the number of rows in the dataset. A `Definitions` object is defined that will allow Dagster to load the `iris_dataset_size` asset.

The `workspace.yaml` file tells Dagster where to find the `Definitions` object.
2 changes: 1 addition & 1 deletion examples/deploy_k8s_beta/workspace.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load_from:
- python_file:
relative_path: iris_analysis/__init__.py
relative_path: iris_analysis/definitions.py
location_name: iris_analysis
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@

dagsterApiGrpcArgs:
- "--python-file"
- "/iris_analysis/__init__.py"
- "/iris_analysis/definitions.py"

... # Following configuration omitted for brevity
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load_from:
- python_file:
relative_path: iris_analysis/__init__.py
relative_path: iris_analysis/definitions.py
location_name: iris_analysis

0 comments on commit 0fa09ef

Please sign in to comment.