-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Add Google Drive icon for asset
kinds
tag (#26349)
## Summary & Motivation Add Google Drive icon (24x24 px; 1,100 bytes) for asset `kinds` tag. I often read files from Google Drive using the [google-api-python-client](https://github.com/googleapis/google-api-python-client) and having a dedicated icon instead of the generic [Google](https://github.com/dagster-io/dagster/blob/53a5ad52d668ef805d5cb2d087885595a04f236b/docs/next/public/images/concepts/metadata-tags/kinds/icons/tool-google-color.svg#L4) icon would enhance the UI experience. ## How I Tested These Changes Launched the documentation website locally and verified that the kind was visible in the `Supported Icons` section (as in the screenshot below). <img width="1512" alt="Screenshot 2024-12-09 at 15 03 47" src="https://github.com/user-attachments/assets/97edb4b7-752d-4533-bcfa-1b040ff0eac0"> ## Changelog > [ui] Add Google Drive icon for kind tags
- Loading branch information
1 parent
388ae77
commit 1319682
Showing
4 changed files
with
13 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...ext/public/images/concepts/metadata-tags/kinds/icons/tool-googledrive-color.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...dagster-ui/packages/ui-core/src/graph/kindtag-images/tool-googledrive-color.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1319682
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagster-docs ready!
✅ Preview
https://dagster-docs-7i0k4z22i-elementl.vercel.app
https://master.dagster.dagster-docs.io
Built with commit 1319682.
This pull request is being automatically deployed with vercel-action
1319682
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-iwh46uwv0-elementl.vercel.app
Built with commit 1319682.
This pull request is being automatically deployed with vercel-action