Skip to content

Commit

Permalink
[ui] Add Google Drive icon for asset kinds tag (#26349)
Browse files Browse the repository at this point in the history
## Summary & Motivation
Add Google Drive icon (24x24 px; 1,100 bytes) for asset `kinds` tag. 

I often read files from Google Drive using the
[google-api-python-client](https://github.com/googleapis/google-api-python-client)
and having a dedicated icon instead of the generic
[Google](https://github.com/dagster-io/dagster/blob/53a5ad52d668ef805d5cb2d087885595a04f236b/docs/next/public/images/concepts/metadata-tags/kinds/icons/tool-google-color.svg#L4)
icon would enhance the UI experience.

## How I Tested These Changes
Launched the documentation website locally and verified that the kind
was visible in the `Supported Icons` section (as in the screenshot
below).

<img width="1512" alt="Screenshot 2024-12-09 at 15 03 47"
src="https://github.com/user-attachments/assets/97edb4b7-752d-4533-bcfa-1b040ff0eac0">

## Changelog
> [ui] Add Google Drive icon for kind tags
  • Loading branch information
dragos-pop authored Dec 16, 2024
1 parent 388ae77 commit 1319682
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions docs/content/concepts/metadata-tags/kind-tags.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ Some kinds are given a branded icon in the UI. We currently support nearly 200 u
| `go` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-go-color.svg" width={20} height={20} /> |
| `google` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-google-color.svg" width={20} height={20} /> |
| `googlecloud` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-googlecloud-color.svg" width={20} height={20} /> |
| `googledrive` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-googledrive-color.svg" width={20} height={20} /> |
| `googlesheets` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-googlesheets-color.svg" width={20} height={20} /> |
| `graphql` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-graphql-color.svg" width={20} height={20} /> |
| `greatexpectations` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-greatexpectations-color.svg" width={20} height={20} /> |
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions js_modules/dagster-ui/packages/ui-core/src/graph/OpTags.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ import gitlab from './kindtag-images/tool-gitlab-color.svg';
import go from './kindtag-images/tool-go-color.svg';
import google from './kindtag-images/tool-google-color.svg';
import googlecloud from './kindtag-images/tool-googlecloud-color.svg';
import googledrive from './kindtag-images/tool-googledrive-color.svg';
import googlesheets from './kindtag-images/tool-googlesheets-color.svg';
import graphql from './kindtag-images/tool-graphql-color.svg';
import greatexpectations from './kindtag-images/tool-greatexpectations-color.svg';
Expand Down Expand Up @@ -248,6 +249,7 @@ export type KnownTagType =
| 'powerbi'
| 'gcp'
| 'googlecloud'
| 'googledrive'
| 'looker'
| 'tableau'
| 'segment'
Expand Down Expand Up @@ -580,6 +582,10 @@ export const KNOWN_TAGS: Record<KnownTagType, KnownTag> = {
icon: googlecloud,
content: 'Google Cloud',
},
googledrive: {
icon: googledrive,
content: 'Google Drive',
},
looker: {
icon: looker,
content: 'Looker',
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

2 comments on commit 1319682

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs ready!

✅ Preview
https://dagster-docs-7i0k4z22i-elementl.vercel.app
https://master.dagster.dagster-docs.io

Built with commit 1319682.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-iwh46uwv0-elementl.vercel.app

Built with commit 1319682.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.