Skip to content

Commit

Permalink
[graphql] dont wipe instance in checks test (#26134)
Browse files Browse the repository at this point in the history
we already wipe in the context fixture 

https://github.com/dagster-io/dagster/blob/master/python_modules/dagster-graphql/dagster_graphql_tests/graphql/graphql_context_test_suite.py#L792
so this just messes up places that change that out

## How I Tested These Changes

bk
  • Loading branch information
alangenfeld authored Nov 26, 2024
1 parent e9e7c31 commit 279c989
Showing 1 changed file with 3 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,6 @@ def test_asset_check_asset_node_job_selection(self, graphql_context: WorkspaceRe
}

def test_asset_check_execution_cursoring(self, graphql_context: WorkspaceRequestContext):
graphql_context.instance.wipe()

run_ids = [create_run_for_test(graphql_context.instance).run_id for _ in range(10)]
for run_id in run_ids:
graphql_context.instance.event_log_storage.store_event(
Expand Down Expand Up @@ -460,8 +458,6 @@ def test_asset_check_execution_cursoring(self, graphql_context: WorkspaceRequest
assert execution["runId"] == expected_run_id

def test_asset_check_executions(self, graphql_context: WorkspaceRequestContext):
graphql_context.instance.wipe()

run_id_one, run_id_two = [make_new_run_id() for _ in range(2)]
create_run_for_test(graphql_context.instance, run_id=run_id_one)

Expand Down Expand Up @@ -535,8 +531,6 @@ def test_asset_check_executions(self, graphql_context: WorkspaceRequestContext):
}

def test_asset_check_events(self, graphql_context: WorkspaceRequestContext):
graphql_context.instance.wipe()

run_id_one, run_id_two = [make_new_run_id() for _ in range(2)]
create_run_for_test(graphql_context.instance, run_id=run_id_one)

Expand Down Expand Up @@ -580,8 +574,6 @@ def test_asset_check_events(self, graphql_context: WorkspaceRequestContext):
}

def test_asset_check_failure(self, graphql_context: WorkspaceRequestContext):
graphql_context.instance.wipe()

run = create_run_for_test(graphql_context.instance)

graphql_context.instance.event_log_storage.store_event(
Expand Down Expand Up @@ -621,7 +613,6 @@ def test_asset_check_failure(self, graphql_context: WorkspaceRequestContext):

def test_latest_execution(self, graphql_context: WorkspaceRequestContext):
instance = graphql_context.instance
instance.wipe()

def new_materialization() -> EventLogRecord:
"""Stores a materialization in a new run, and asserts that latest execustion is null."""
Expand Down Expand Up @@ -857,7 +848,9 @@ def test_launch_subset_with_only_check(self, graphql_context: WorkspaceRequestCo
}
},
)
assert result.data["launchPipelineExecution"]["__typename"] == "LaunchRunSuccess"
assert (
result.data["launchPipelineExecution"]["__typename"] == "LaunchRunSuccess"
), result.data

run_id = result.data["launchPipelineExecution"]["run"]["runId"]

Expand Down Expand Up @@ -1308,8 +1301,6 @@ def test_step_key(self, graphql_context: WorkspaceRequestContext):
}

def test_deleted_run(self, graphql_context: WorkspaceRequestContext):
graphql_context.instance.wipe()

run_id = make_new_run_id()
run = create_run_for_test(graphql_context.instance, run_id=run_id)

Expand Down

0 comments on commit 279c989

Please sign in to comment.