Skip to content

Commit

Permalink
Fix colors on daggy u popover (#19857)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Fix colors on dagster university product tour.

Blueprint's dark theme was overriding the link color in the popover and
blueprints arrow was on a layer below the popover which made it look a
different color due to the box shadow overlaying on it before.

## How I Tested These Changes
<img width="327" alt="Screenshot 2024-02-16 at 12 36 16 AM"
src="https://github.com/dagster-io/dagster/assets/2286579/c64afdaf-42a5-45ea-bc33-412aba6e8110">
  • Loading branch information
salazarm authored Feb 16, 2024
1 parent 477d8d2 commit 2c077d0
Showing 1 changed file with 11 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,17 @@ export const GlobalPopoverStyle = createGlobalStyle`
fill-opacity: 0.7;
}
.dagster-popover.bp4-dark .bp4-popover2-arrow {
z-index: 9;
&:before {
display: none;
}
}
.dagster-popover.bp4-dark a {
color: inherit;
}
.dagster-popover .bp4-popover2.bp4-dark .bp4-popover2-content,
.bp4-dark .dagster-popover .bp4-popover2 .bp4-popover2-content {
background-color: ${Colors.tooltipBackground()};
Expand Down

1 comment on commit 2c077d0

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-r6bi31p4d-elementl.vercel.app

Built with commit 2c077d0.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.