Fix type annotation List -> list (#27044)

#26934 added the old style `List` which is not imported anymore and tests are currently broken. ### Testing The `helm` suite in buildkite tests should pass.
dagster-io · Jan 11, 2025 · 32dc531 · 32dc531
1 parent a712a8e
commit 32dc531
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/helm/dagster/schema/schema/charts/dagster/subschema/daemon.py b/helm/dagster/schema/schema/charts/dagster/subschema/daemon.py
@@ -107,5 +107,5 @@ class Daemon(BaseModel, extra="forbid"):
     volumeMounts: Optional[list[kubernetes.VolumeMount]] = None
     volumes: Optional[list[kubernetes.Volume]] = None
     initContainerResources: Optional[kubernetes.Resources] = None
-    extraContainers: Optional[List[kubernetes.Container]] = None
-    extraPrependedInitContainers: Optional[List[kubernetes.InitContainer]] = None
+    extraContainers: Optional[list[kubernetes.Container]] = None
+    extraPrependedInitContainers: Optional[list[kubernetes.InitContainer]] = None
diff --git a/helm/dagster/schema/schema/charts/dagster/subschema/migrate.py b/helm/dagster/schema/schema/charts/dagster/subschema/migrate.py
@@ -1,4 +1,4 @@
-from typing import List, Optional
+from typing import Optional
 
 from pydantic import BaseModel
 
@@ -7,5 +7,5 @@
 
 class Migrate(BaseModel):
     enabled: bool
-    extraContainers: Optional[List[kubernetes.Container]]
-    initContainers: Optional[List[kubernetes.Container]]
+    extraContainers: Optional[list[kubernetes.Container]]
+    initContainers: Optional[list[kubernetes.Container]]
diff --git a/helm/dagster/schema/schema/charts/dagster/subschema/webserver.py b/helm/dagster/schema/schema/charts/dagster/subschema/webserver.py
@@ -48,5 +48,5 @@ class Webserver(BaseModel, extra="forbid"):
     volumeMounts: Optional[list[kubernetes.VolumeMount]] = None
     volumes: Optional[list[kubernetes.Volume]] = None
     initContainerResources: Optional[kubernetes.Resources] = None
-    extraContainers: Optional[List[kubernetes.Container]] = None
-    extraPrependedInitContainers: Optional[List[kubernetes.InitContainer]] = None
+    extraContainers: Optional[list[kubernetes.Container]] = None
+    extraPrependedInitContainers: Optional[list[kubernetes.InitContainer]] = None