feature flag asset graph sidebar

dagster-io · Sep 20, 2023 · 3aa9b78 · 3aa9b78
1 parent e245fed
commit 3aa9b78
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/app/Flags.tsx b/js_modules/dagster-ui/packages/ui-core/src/app/Flags.tsx
@@ -14,6 +14,7 @@ export const FeatureFlag = {
   flagSidebarResources: 'flagSidebarResources' as const,
   flagHorizontalDAGs: 'flagHorizontalDAGs' as const,
   flagDisableAutoLoadDefaults: 'flagDisableAutoLoadDefaults' as const,
+  flagDAGSidebar: 'flagDAGSidebar' as const,
 };
 export type FeatureFlagType = keyof typeof FeatureFlag;
 

diff --git a/js_modules/dagster-ui/packages/ui-core/src/app/getVisibleFeatureFlagRows.tsx b/js_modules/dagster-ui/packages/ui-core/src/app/getVisibleFeatureFlagRows.tsx
@@ -32,4 +32,8 @@ export const getVisibleFeatureFlagRows = () => [
     key: 'Experimental horizontal asset DAGs',
     flagType: FeatureFlag.flagHorizontalDAGs,
   },
+  {
+    key: 'Experimental DAG sidebar',
+    flagType: FeatureFlag.flagDAGSidebar,
+  },
 ];
diff --git a/js_modules/dagster-ui/packages/ui-core/src/asset-graph/AssetGraphExplorer.tsx b/js_modules/dagster-ui/packages/ui-core/src/asset-graph/AssetGraphExplorer.tsx
@@ -145,7 +145,7 @@ const AssetGraphExplorerWithData: React.FC<WithDataProps> = ({
   const findAssetLocation = useFindAssetLocation();
   const {layout, loading, async} = useAssetLayout(assetGraphData);
   const viewportEl = React.useRef<SVGViewport>();
-  const {flagHorizontalDAGs} = useFeatureFlags();
+  const {flagHorizontalDAGs, flagDAGSidebar} = useFeatureFlags();
 
   const [highlighted, setHighlighted] = React.useState<string | null>(null);
 
@@ -449,7 +449,7 @@ const AssetGraphExplorerWithData: React.FC<WithDataProps> = ({
             </Box>
           </Box>
           <QueryOverlay>
-            {showSidebar ? null : (
+            {showSidebar || !flagDAGSidebar ? null : (
               <Tooltip content="Show sidebar">
                 <Button
                   icon={<Icon name="panel_show_left" />}
@@ -497,7 +497,7 @@ const AssetGraphExplorerWithData: React.FC<WithDataProps> = ({
     />
   );
 
-  if (showSidebar) {
+  if (showSidebar && flagDAGSidebar) {
     return (
       <SplitPanelContainer
         key="explorer-wrapper"