Skip to content

Commit

Permalink
[ui] Dash icon (#20341)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Replace `subtract` icon with `dash` icon, as defined in Figma.

## How I Tested These Changes

Storybook
  • Loading branch information
hellendag authored Mar 8, 2024
1 parent 01715ac commit 3e6ef06
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ import concept_book from '../icon-svgs/concept-book.svg';
import console_icon from '../icon-svgs/console.svg';
import content_copy from '../icon-svgs/content_copy.svg';
import corporate_fare from '../icon-svgs/corporate_fare.svg';
import dash from '../icon-svgs/dash.svg';
import datatype_array from '../icon-svgs/datatype_array.svg';
import datatype_bool from '../icon-svgs/datatype_bool.svg';
import datatype_number from '../icon-svgs/datatype_number.svg';
Expand Down Expand Up @@ -147,7 +148,6 @@ import star from '../icon-svgs/star.svg';
import star_outline from '../icon-svgs/star_outline.svg';
import status from '../icon-svgs/status.svg';
import sticky_note from '../icon-svgs/sticky_note.svg';
import subtract from '../icon-svgs/subtract.svg';
import sync_alt from '../icon-svgs/sync_alt.svg';
import sync_problem from '../icon-svgs/sync_problem.svg';
import table_view from '../icon-svgs/table_view.svg';
Expand Down Expand Up @@ -233,6 +233,7 @@ export const Icons = {
chat_support,
changes_present,
concept_book,
dash,
open_in_new,
folder,
tag,
Expand Down Expand Up @@ -334,7 +335,6 @@ export const Icons = {
settings_backup_restore,
sort_by_alpha,
source,
subtract,
speed,
splitscreen,
stacks,
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ const LineageDepthControl = ({
<Button
disabled={value <= 1}
onClick={() => onChange(value - 1)}
icon={<Icon name="subtract" />}
icon={<Icon name="dash" />}
/>
<TextInput
min={1}
Expand Down

2 comments on commit 3e6ef06

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-1zo4djnxj-elementl.vercel.app

Built with commit 3e6ef06.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-ezd7zofnl-elementl.vercel.app

Built with commit 3e6ef06.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.