fix up tests

dagster-io · Oct 10, 2024 · 3e9cd0b · 3e9cd0b
1 parent 047633a
commit 3e9cd0b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/python_modules/dagster-graphql/dagster_graphql/schema/roots/mutation.py b/python_modules/dagster-graphql/dagster_graphql/schema/roots/mutation.py
@@ -373,7 +373,6 @@ class GrapheneReexecuteBackfillMutation(graphene.Mutation):
     Output = graphene.NonNull(GrapheneLaunchBackfillResult)
 
     class Arguments:
-        # backfillId = graphene.NonNull(graphene.String)
         reexecutionParams = graphene.Argument(GrapheneReexecutionParams)
 
     class Meta:
@@ -384,7 +383,7 @@ class Meta:
     def mutate(
         self,
         graphene_info: ResolveInfo,
-        reexecutionParams: Optional[GrapheneReexecutionParams] = None,
+        reexecutionParams: GrapheneReexecutionParams,
     ):
         return retry_partition_backfill(
             graphene_info,

diff --git a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_partition_backfill.py b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_partition_backfill.py
@@ -1714,7 +1714,7 @@ def test_reexecute_successful_asset_backfill(self, graphql_context):
         assert result.data
         assert result.data["reexecutePartitionBackfill"]["__typename"] == "PythonError"
         assert (
-            "Cannot re-execute an asset backfill that has no missing materializations"
+            "Cannot re-execute from failure an asset backfill that has no missing materializations"
             in result.data["reexecutePartitionBackfill"]["message"]
         )
 
@@ -1858,7 +1858,7 @@ def test_reexecute_asset_backfill_still_in_progress(self, graphql_context):
         retried_backfill = graphql_context.instance.get_backfill(retry_backfill_id)
 
         assert (
-            first_backfill.asset_backfill_data.failed_and_downstream_subset
+            first_backfill.asset_backfill_data.target_subset
             == retried_backfill.asset_backfill_data.target_subset
         )
         assert retried_backfill.tags.get(PARENT_BACKFILL_ID_TAG) == backfill_id
@@ -1964,7 +1964,7 @@ def test_reexecute_asset_backfill_twice(self, graphql_context):
             graphql_context,
             RETRY_BACKFILL_MUTATION,
             variables={
-                "reexecutionParams": {"parentRunId": backfill_id, "strategy": "FROM_FAILURE"},
+                "reexecutionParams": {"parentRunId": retry_backfill_id, "strategy": "FROM_FAILURE"},
             },
         )
 
@@ -2078,7 +2078,7 @@ def test_retry_job_backfill(self, graphql_context):
         assert result.data["partitionBackfillOrError"]["status"] == "REQUESTED"
         assert result.data["partitionBackfillOrError"]["numCancelable"] == 2
         assert len(result.data["partitionBackfillOrError"]["partitionNames"]) == 2
-        assert result.data["partitionBackfillOrError"]["fromFailure"]
+        assert not result.data["partitionBackfillOrError"]["fromFailure"]
 
     def test_retry_in_progress_job_backfill(self, graphql_context):
         repository_selector = infer_repository_selector(graphql_context)