Skip to content

Commit

Permalink
take storage_kind label off the asset node
Browse files Browse the repository at this point in the history
  • Loading branch information
sryza committed Aug 1, 2024
1 parent bcd0b86 commit 477ea20
Showing 1 changed file with 2 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,7 @@ import {ChangedReasonsTag, MinimalNodeChangedDot} from '../assets/ChangedReasons
import {MinimalNodeStaleDot, StaleReasonsTag, isAssetStale} from '../assets/Stale';
import {AssetChecksStatusSummary} from '../assets/asset-checks/AssetChecksStatusSummary';
import {assetDetailsPathForKey} from '../assets/assetDetailsPathForKey';
import {
AssetComputeKindTag,
AssetStorageKindTag,
isCanonicalStorageKindTag,
} from '../graph/KindTags';
import {AssetComputeKindTag} from '../graph/KindTags';
import {DefinitionTag} from '../graphql/types';
import {StaticSetFilter} from '../ui/BaseFilters/useStaticSetFilter';
import {markdownToPlaintext} from '../ui/markdownToPlaintext';
Expand All @@ -31,15 +27,13 @@ interface Props {
definition: AssetNodeFragment;
selected: boolean;
computeKindTagsFilter?: StaticSetFilter<string>;
storageKindTagsFilter?: StaticSetFilter<DefinitionTag>;
}

export const AssetNode = React.memo(
({definition, selected, computeKindTagsFilter, storageKindTagsFilter}: Props) => {
({definition, selected, computeKindTagsFilter}: Props) => {
const isSource = definition.isSource;

const {liveData} = useAssetLiveData(definition.assetKey);
const storageKindTag = definition.tags?.find(isCanonicalStorageKindTag);
return (
<AssetInsetForHoverEffect>
<Box
Expand Down Expand Up @@ -74,13 +68,6 @@ export const AssetNode = React.memo(
)}
</AssetNodeBox>
<Box flex={{direction: 'row-reverse', gap: 8}}>
{storageKindTag && (
<AssetStorageKindTag
storageKind={storageKindTag.value}
style={{position: 'relative', paddingTop: 7, margin: 0}}
currentPageFilter={storageKindTagsFilter}
/>
)}
<AssetComputeKindTag
definition={definition}
style={{position: 'relative', paddingTop: 7, margin: 0}}
Expand Down

0 comments on commit 477ea20

Please sign in to comment.