Skip to content

Commit

Permalink
[Popover] default enforceFocus to false to prevent issue with neste…
Browse files Browse the repository at this point in the history
…d popovers (#21012)

## Summary & Motivation

Fixes:
https://linear.app/dagster-labs/issue/FE-252/daggy-u-dialog-blocks-input-in-textboxes-during-serverless-nux

Nested blueprint popovers are buggy, blueprint recommends setting
`enforceFocus=false` on the outermost popover in this case. We're going
to set enforceFocus=false as the default instead of on a case by case
basis to prevent further instances of the bug and because there hasn't
been any case where we intentionally wanted to enforce focus.

## How I Tested These Changes

With storybook
  • Loading branch information
salazarm authored Apr 4, 2024
1 parent d0bc7d4 commit 4a425d0
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ export const Popover = (props: Props) => {
<Popover2
minimal
autoFocus={false}
enforceFocus={false}
{...props}
popoverClassName={`dagster-popover ${props.popoverClassName}`}
modifiers={deepmerge(
Expand Down

1 comment on commit 4a425d0

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-dpk08m4t4-elementl.vercel.app

Built with commit 4a425d0.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.