use jobName as fallback if only launching 1 job

dagster-io · Dec 19, 2024 · 4a5be44 · 4a5be44
1 parent a1e8f85
commit 4a5be44
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 7 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/launchpad/useLaunchMultipleRunsWithTelemetry.ts b/js_modules/dagster-ui/packages/ui-core/src/launchpad/useLaunchMultipleRunsWithTelemetry.ts
@@ -24,18 +24,29 @@ export function useLaunchMultipleRunsWithTelemetry() {
   const history = useHistory();
 
   return useCallback(
-    async (variables: LaunchMultipleRunsMutationVariables, behavior: LaunchBehavior) => {
+    async (
+      variables: LaunchMultipleRunsMutationVariables,
+      behavior: LaunchBehavior,
+      jobName: string,
+    ) => {
       try {
         const executionParamsList = Array.isArray(variables.executionParamsList)
           ? variables.executionParamsList
           : [variables.executionParamsList];
-        const jobNames = executionParamsList.map(
+
+        let jobNames = executionParamsList.map(
           (params) => params.selector.jobName || params.selector.pipelineName,
         );
 
         if (
-          jobNames.length !== executionParamsList.length ||
-          jobNames.includes(undefined) ||
+          (executionParamsList.length === 1 && jobNames.includes(undefined)) ||
+          jobNames.includes(null)
+        ) {
+          jobNames = [jobName];
+        }
+
+        if (
+          (jobNames.length !== executionParamsList.length && jobNames.includes(undefined)) ||
           jobNames.includes(null)
         ) {
           throw new Error(

diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/EvaluateScheduleDialog.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/EvaluateScheduleDialog.tsx
@@ -190,15 +190,22 @@ const EvaluateSchedule = ({repoAddress, name, onClose, jobName}: Props) => {
 
     try {
       if (executionParamsList) {
-        await launchMultipleRunsWithTelemetry({executionParamsList}, 'toast');
+        await launchMultipleRunsWithTelemetry({executionParamsList}, 'toast', jobName);
       }
     } catch (e) {
       console.error(e);
     }
 
     setLaunching(false);
     onClose();
-  }, [canLaunchAll, executionParamsList, launchMultipleRunsWithTelemetry, onClose, trackEvent]);
+  }, [
+    canLaunchAll,
+    executionParamsList,
+    jobName,
+    launchMultipleRunsWithTelemetry,
+    onClose,
+    trackEvent,
+  ]);
 
   const content = useMemo(() => {
     // launching all runs state

diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/SensorDryRunDialog.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/SensorDryRunDialog.tsx
@@ -196,7 +196,7 @@ const SensorDryRun = ({repoAddress, name, currentCursor, onClose, jobName}: Prop
 
     try {
       if (executionParamsList) {
-        await launchMultipleRunsWithTelemetry({executionParamsList}, 'toast');
+        await launchMultipleRunsWithTelemetry({executionParamsList}, 'toast', jobName);
         onCommitTickResult(); // persist tick
       }
     } catch (e) {
@@ -208,6 +208,7 @@ const SensorDryRun = ({repoAddress, name, currentCursor, onClose, jobName}: Prop
   }, [
     canLaunchAll,
     executionParamsList,
+    jobName,
     launchMultipleRunsWithTelemetry,
     onClose,
     onCommitTickResult,