address comments

dagster-io · Dec 3, 2024 · 4de4c36 · 4de4c36
1 parent 07982e0
commit 4de4c36
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-components/src/components/NonIdealState.tsx b/js_modules/dagster-ui/packages/ui-components/src/components/NonIdealState.tsx
@@ -31,6 +31,7 @@ export const NonIdealState = ({
       flex={{gap: 20, alignItems: singleContentElement ? 'center' : 'flex-start'}}
       background={Colors.backgroundLight()}
       padding={24}
+      className="non-ideal-state-parent-box"
       style={{
         margin: 'auto',
         borderRadius: 8,

diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/DryRunRequestTable.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/DryRunRequestTable.tsx
@@ -94,7 +94,7 @@ export const RunRequestTable = ({runRequests, isJob, repoAddress, mode, jobName}
 function PreviewButton({onClick}: {onClick: () => void}) {
   return (
     <Tooltip content="Preview run config and tags" placement="left-start">
-      <Button icon={<Icon name="data_object" />} onClick={onClick}></Button>
+      <Button icon={<Icon name="data_object" />} onClick={onClick} />
     </Tooltip>
   );
 }
diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/SensorDryRunDialog.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/SensorDryRunDialog.tsx
@@ -136,7 +136,7 @@ const SensorDryRun = ({repoAddress, name, currentCursor, onClose, jobName}: Prop
     setSubmitting(false);
   }, [sensorDryRun, sensorSelector, cursor, name]);
 
-  const onPersistCursorValue = useCallback(async () => {
+  const onCommitTickResult = useCallback(async () => {
     const cursor = sensorExecutionData?.evaluationResult?.cursor;
     if (!cursor) {
       return;
@@ -176,10 +176,6 @@ const SensorDryRun = ({repoAddress, name, currentCursor, onClose, jobName}: Prop
     }
   }, [sensorExecutionData?.evaluationResult?.cursor, sensorSelector, setCursorMutation]);
 
-  const onCommitTickResult = useCallback(() => {
-    onPersistCursorValue();
-  }, [onPersistCursorValue]);
-
   const launchMultipleRunsWithTelemetry = useLaunchMultipleRunsWithTelemetry();
 
   const canLaunchAll = useMemo(() => {
@@ -532,8 +528,8 @@ const ComputedCursorGrid = styled.div`
   }
 `;
 
-const SkipReasonNonIdealStateWrapper = styled(Box)`
-  > div:first-child {
+const SkipReasonNonIdealStateWrapper = styled.div`
+  .non-ideal-state-parent-box {
     margin: auto !important;
     width: unset !important;
     max-width: unset !important;