Skip to content

Commit

Permalink
incorporate checkbox value when querying for status counts (#25070)
Browse files Browse the repository at this point in the history
## Summary & Motivation
Updates the runs feed UI to pass the value of the `show runs within
backfills` checkbox to the counts query so that we display the correct
number of results in the status tabs

## How I Tested These Changes
<img width="1440" alt="Screenshot 2024-10-04 at 4 16 34 PM"
src="https://github.com/user-attachments/assets/a0ac653e-10a8-4579-84aa-1ec8fa858f36">
<img width="1440" alt="Screenshot 2024-10-04 at 4 16 47 PM"
src="https://github.com/user-attachments/assets/140e6f03-9ecd-4ea9-9fb0-79dc1e6bb0fe">

## Changelog


- [ ] `NEW` _(added new feature or capability)_
- [X] `BUGFIX` [ui] The experimental Runs page now correctly shows the
number of Queued and In Progress runs and backfills based on whether the
"Show runs within backfills" box is checked.
- [ ] `DOCS` _(added or updated documentation)_
  • Loading branch information
jamiedemaria authored Oct 7, 2024
1 parent aac7392 commit 52816a4
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 5 deletions.
2 changes: 1 addition & 1 deletion js_modules/dagster-ui/packages/ui-core/client.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 14 additions & 3 deletions js_modules/dagster-ui/packages/ui-core/src/runs/RunsFeedTabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export const useRunsFeedTabs = (filter: RunsFilter = {}, includeRunsFromBackfill
variables: {
queuedFilter: {...filter, statuses: Array.from(queuedStatuses)},
inProgressFilter: {...filter, statuses: Array.from(inProgressStatuses)},
includeRunsFromBackfills,
},
},
);
Expand Down Expand Up @@ -140,13 +141,23 @@ export const useSelectedRunsFeedTab = (filterTokens: TokenizingFieldValue[]) =>
};

export const RUN_FEED_TABS_COUNT_QUERY = gql`
query RunFeedTabsCountQuery($queuedFilter: RunsFilter!, $inProgressFilter: RunsFilter!) {
queuedCount: runsFeedCountOrError(filter: $queuedFilter) {
query RunFeedTabsCountQuery(
$queuedFilter: RunsFilter!
$inProgressFilter: RunsFilter!
$includeRunsFromBackfills: Boolean!
) {
queuedCount: runsFeedCountOrError(
filter: $queuedFilter
includeRunsFromBackfills: $includeRunsFromBackfills
) {
... on RunsFeedCount {
count
}
}
inProgressCount: runsFeedCountOrError(filter: $inProgressFilter) {
inProgressCount: runsFeedCountOrError(
filter: $inProgressFilter
includeRunsFromBackfills: $includeRunsFromBackfills
) {
... on RunsFeedCount {
count
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 comment on commit 52816a4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-3k1dzmlmi-elementl.vercel.app

Built with commit 52816a4.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.