-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(dbt): use correct relation identifier when creating
BaseRelation
(
#22823) ## Summary & Motivation When creating the `BaseRelation`, we want to use the name of the table that's created in the data warehouse so that we can properly query the relation. Previously, we were using `dbt_resource_props["name"]` as the identifier, which is the dbt's reference to that table. Instead, we should use the underlying identifier name. For dbt sources, this is `dbt_resource_props["identifier"]`. For dbt models and seeds, this is `dbt_resource_props["alias"]`. ## How I Tested These Changes pytest: added dbt aliases for source and model in existing `test_dagster_metadata` project
- Loading branch information
1 parent
4e0c5fe
commit 58ad7b0
Showing
3 changed files
with
25 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters