oof (#25787)

## Summary & Motivation Needed to invert the condition
dagster-io · Nov 7, 2024 · 5a1c831 · 5a1c831
1 parent 23824c1
commit 5a1c831
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.buildkite/dagster-buildkite/dagster_buildkite/cli.py b/.buildkite/dagster-buildkite/dagster_buildkite/cli.py
@@ -1,4 +1,3 @@
-import logging
 from pathlib import Path
 
 from dagster_buildkite.git import GitInfo

diff --git a/.buildkite/dagster-buildkite/dagster_buildkite/package_spec.py b/.buildkite/dagster-buildkite/dagster_buildkite/package_spec.py
@@ -253,7 +253,7 @@ def skip_reason(self) -> Optional[str]:
         """
         # If self._should_skip is not None, then the result is cached on self._skip_reason and we can return it.
         if self._should_skip is not None:
-            if self._should_skip is False:
+            if self._should_skip is True:
                 assert (
                     self._skip_reason is not None
                 ), "Expected skip reason to be set if self._should_skip is True."