Skip to content

Commit

Permalink
add 'pathType' field to 'dagsterWebserver' ingress (#24419)
Browse files Browse the repository at this point in the history
## Summary & Motivation
The 'PathType' field is missing from the ingress template for
'succeedingPaths' in 'dagsterWebserver' paths causing the helm
deployment to fail if a 'succeedingPath' has been declared in the input
values file.

[Issue Link](#24420)

## How I Tested These Changes
- Added the 'pathType' field to and re-deployed the helm chart without
error.
- Confirmed that the resulting ingress resource was created
successfully.

## Changelog

Insert changelog entry or "NOCHANGELOG" here.
- [x] `BUGFIX` add 'pathType' field to 'dagsterWebserver' ingress in
ingress.yaml
  • Loading branch information
ja14000 authored Sep 12, 2024
1 parent 9eb0b5d commit 5eab1c4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions helm/dagster/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ spec:
number: {{ $_.Values.dagsterWebserver.service.port | default 80 }}
{{- range $_.Values.ingress.dagsterWebserver.succeedingPaths }}
- path: {{ .path }}
pathType: {{ .pathType }}
backend:
service:
name: {{ .serviceName }}
Expand Down

0 comments on commit 5eab1c4

Please sign in to comment.