formalize the delay between making a run and a backfill in tests

dagster-io · Aug 8, 2024 · 60c8119 · 60c8119
1 parent fa84a84
commit 60c8119
Show file tree

Hide file tree

Showing 5 changed files with 197 additions and 52 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/graphql/possibleTypes.generated.json b/js_modules/dagster-ui/packages/ui-core/src/graphql/possibleTypes.generated.json
diff --git a/js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts b/js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts
diff --git a/python_modules/dagster-graphql/dagster_graphql/implementation/fetch_runs.py b/python_modules/dagster-graphql/dagster_graphql/implementation/fetch_runs.py
@@ -456,7 +456,9 @@ def get_mega_runs(
         instance, cursor=mega_run_cursor.run_cursor, limit=fetch_limit
     )
 
-    if fetch_limit:
+    if (
+        fetch_limit and limit
+    ):  # if fetch_limit is non-None then limit must also be non-None, but check for pyright
         # if we fetched limit+1 of either runs or backfills, we know there must be more results
         # to fetch on the next call since we will return limit results for this call. Additionally,
         # if we fetched more than limit of runs and backfill combined, we know there are more results

diff --git a/python_modules/dagster-graphql/dagster_graphql/schema/backfill.py b/python_modules/dagster-graphql/dagster_graphql/schema/backfill.py
@@ -123,7 +123,7 @@ class GrapheneBulkActionStatus(graphene.Enum):
     class Meta:
         name = "BulkActionStatus"
 
-    def to_dagster_run_status(self) -> GrapheneRunStatus:
+    def to_dagster_run_status(self):
         """Placeholder for this PR. Will do a more thurough pass to accurately convert backfill status
         to DagsterRunStatus in a stacked branch.
         """