Skip to content

Commit

Permalink
[components] Fix dg-cli in automation tests (#26389)
Browse files Browse the repository at this point in the history
Fixes BK.
  • Loading branch information
smackesey authored Dec 10, 2024
1 parent beeefe2 commit 62c3877
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
10 changes: 9 additions & 1 deletion python_modules/automation/automation_tests/test_repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
import subprocess
from pathlib import Path

# Some libraries are excluded because they lack a Dagster dependency, which is a prerequisite for
# registering in the DagsterLibraryRegistry.
EXCLUDE_LIBRARIES = ["dg-cli"]


def test_all_libraries_register() -> None:
# attempt to ensure all libraries in the repository register with DagsterLibraryRegistry
Expand All @@ -11,7 +15,11 @@ def test_all_libraries_register() -> None:
assert str(library_dir).endswith("python_modules/libraries")

for library in os.listdir(library_dir):
if library.startswith(".") or library.endswith("CONTRIBUTING.md"):
if (
library in EXCLUDE_LIBRARIES
or library.startswith(".")
or library.endswith("CONTRIBUTING.md")
):
continue
result = subprocess.run(["grep", register_call, (library_dir / library), "-r"], check=False)
assert (
Expand Down
1 change: 1 addition & 0 deletions python_modules/automation/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ deps =
-e ../libraries/dagster-polars
-e ../libraries/dagster-openai
-e ../libraries/dagster-airlift
-e ../libraries/dg-cli
-e .
allowlist_externals =
/bin/bash
Expand Down

0 comments on commit 62c3877

Please sign in to comment.