addressing feedback

dagster-io · Mar 7, 2024 · 67a2a67 · 67a2a67
1 parent 2b794f2
commit 67a2a67
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/app/ContentRoot.tsx b/js_modules/dagster-ui/packages/ui-core/src/app/ContentRoot.tsx
@@ -8,7 +8,6 @@ const WorkspaceRoot = lazy(() => import('../workspace/WorkspaceRoot'));
 const OverviewRoot = lazy(() => import('../overview/OverviewRoot'));
 const FallthroughRoot = lazy(() => import('./FallthroughRoot'));
 const AssetsCatalogRoot = lazy(() => import('../assets/AssetsCatalogRoot'));
-const AssetsOverview = lazy(() => import('../assets/AssetsOverview'));
 const AssetsGroupsGlobalGraphRoot = lazy(() => import('../assets/AssetsGroupsGlobalGraphRoot'));
 const CodeLocationsPage = lazy(() => import('../instance/CodeLocationsPage'));
 const InstanceConfig = lazy(() => import('../instance/InstanceConfig'));

diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetsOverview.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetsOverview.tsx
@@ -114,7 +114,9 @@ function getGreeting(timezone: string) {
       timeZone: timezone === 'Automatic' ? browserTimezone() : timezone,
     }),
   );
-  if (hour < 12) {
+  if (hour < 4) {
+    return 'Good evening';
+  } else if (hour < 12) {
     return 'Good morning';
   } else if (hour < 18) {
     return 'Good afternoon';
@@ -218,11 +220,7 @@ export const AssetsOverview = ({viewerName}: {viewerName?: string}) => {
     <>
       <AssetPageHeader
         assetKey={{path: currentPath}}
-        right={
-          <Box flex={{gap: 12, alignItems: 'center'}}>
-            <ReloadAllButton label="Reload definitions" />
-          </Box>
-        }
+        right={<ReloadAllButton label="Reload definitions" />}
       />
       <Box flex={{direction: 'column'}} style={{height: '100%', overflow: 'auto'}}>
         <Box padding={64} flex={{justifyContent: 'center', alignItems: 'center'}}>