Add test

dagster-io · Dec 13, 2024 · 6bcbaf3 · 6bcbaf3
1 parent 32c75b4
commit 6bcbaf3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/python_modules/libraries/dagster-airbyte/dagster_airbyte/resources.py b/python_modules/libraries/dagster-airbyte/dagster_airbyte/resources.py
@@ -1009,7 +1009,9 @@ def get_job_details(self, job_id: int) -> Mapping[str, Any]:
         )
 
     def cancel_job(self, job_id: int) -> Mapping[str, Any]:
-        return self.make_request(method="DELETE", endpoint=f"jobs/{job_id}")
+        return self._make_request(
+            method="DELETE", endpoint=f"jobs/{job_id}", base_url=self.rest_api_base_url
+        )
 
 
 @experimental

diff --git a/python_modules/libraries/dagster-airbyte/dagster_airbyte_tests/experimental/conftest.py b/python_modules/libraries/dagster-airbyte/dagster_airbyte_tests/experimental/conftest.py
@@ -168,7 +168,7 @@
     "status": "running",
     "jobType": "sync",
     "startTime": "2023-03-25T01:30:50Z",
-    "connectionId": TEST_CONNECTION_ID
+    "connectionId": TEST_CONNECTION_ID,
 }
 
 
@@ -231,4 +231,10 @@ def all_api_mocks_fixture(
         json=SAMPLE_JOB_RESPONSE,
         status=200,
     )
+    fetch_workspace_data_api_mocks.add(
+        method=responses.DELETE,
+        url=f"{AIRBYTE_REST_API_BASE}/{AIRBYTE_REST_API_VERSION}/jobs/{TEST_JOB_ID}",
+        json=SAMPLE_JOB_RESPONSE,
+        status=200,
+    )
     yield fetch_workspace_data_api_mocks
diff --git a/...on_modules/libraries/dagster-airbyte/dagster_airbyte_tests/experimental/test_resources.py b/...on_modules/libraries/dagster-airbyte/dagster_airbyte_tests/experimental/test_resources.py
@@ -130,8 +130,9 @@ def test_basic_resource_request(
     client.get_destination_details(destination_id=TEST_DESTINATION_ID)
     client.start_sync_job(connection_id=TEST_CONNECTION_ID)
     client.get_job_details(job_id=TEST_JOB_ID)
+    client.cancel_job(job_id=TEST_JOB_ID)
 
-    assert len(all_api_mocks.calls) == 6
+    assert len(all_api_mocks.calls) == 7
     # The first call is to create the access token
     api_calls = assert_token_call_and_split_calls(calls=all_api_mocks.calls)
     # The next calls are actual API calls
@@ -142,3 +143,4 @@ def test_basic_resource_request(
     assert_rest_api_call(call=api_calls[2], endpoint=f"destinations/{TEST_DESTINATION_ID}")
     assert_rest_api_call(call=api_calls[3], endpoint="jobs", object_id=TEST_CONNECTION_ID)
     assert_rest_api_call(call=api_calls[4], endpoint=f"jobs/{TEST_JOB_ID}")
+    assert_rest_api_call(call=api_calls[5], endpoint=f"jobs/{TEST_JOB_ID}")