Skip to content

Commit

Permalink
disable run status popover for backfills in runs feed (#24842)
Browse files Browse the repository at this point in the history
## Summary & Motivation
The RunStatusTagWithStats can't get stats for backfills, so instead we
should show the non-stats RunStatusTag for backfills.

I'm having an issue with the size of the tag though, the
RunStatusTagWithStats is the expected size, but RunStatus tag is
strangely wide
<img width="175" alt="Screenshot 2024-09-27 at 9 44 11 AM"
src="https://github.com/user-attachments/assets/6e329c59-7db6-448c-a2af-24045e7c3953">



## How I Tested These Changes
👀 

## Changelog

NOCHANGELOG
  • Loading branch information
jamiedemaria authored Sep 27, 2024
1 parent 0bb7b26 commit 716151a
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions js_modules/dagster-ui/packages/ui-core/src/runs/RunsFeedRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {CreatedByTagCell, CreatedByTagCellWrapper} from './CreatedByTag';
import {QueuedRunCriteriaDialog} from './QueuedRunCriteriaDialog';
import {RUN_ACTIONS_MENU_RUN_FRAGMENT, RunActionsMenu} from './RunActionsMenu';
import {RunRowTags} from './RunRowTags';
import {RunStatusTagWithStats} from './RunStatusTag';
import {RunStatusTag, RunStatusTagWithStats} from './RunStatusTag';
import {DagsterTag} from './RunTag';
import {RunTargetLink} from './RunTargetLink';
import {RunStateSummary, RunTime, titleForRun} from './RunUtils';
Expand Down Expand Up @@ -141,7 +141,13 @@ export const RunsFeedRow = ({
<CreatedByTagCell tags={entry.tags || []} onAddTag={onAddTag} />
</RowCell>
<RowCell>
<RunStatusTagWithStats status={entry.runStatus} runId={entry.id} />
<div>
{entry.__typename === 'PartitionBackfill' ? (
<RunStatusTag status={entry.runStatus} />
) : (
<RunStatusTagWithStats status={entry.runStatus} runId={entry.id} />
)}
</div>
</RowCell>
<RowCell style={{flexDirection: 'column', gap: 4}}>
<RunTime run={runTime} />
Expand Down

1 comment on commit 716151a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-cptoj08yp-elementl.vercel.app

Built with commit 716151a.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.