Skip to content

Commit

Permalink
[2/n] [RFC] add 'Launch all' button on sensor/schedule evaluation res…
Browse files Browse the repository at this point in the history
…ult modals (#25323)

## Summary & Motivation
Linear:
https://linear.app/dagster-labs/issue/FE-627/add-launch-all-frontend

Add "Launch all" button to these evaluation result modals


![image](https://github.com/user-attachments/assets/f9af2a71-4915-4d08-84d0-806fdd5d0f97)

![image](https://github.com/user-attachments/assets/e9e9eac0-01d9-41dd-8723-5f48d4656363)


## How I Tested These Changes
Tested locally
  • Loading branch information
dliu27 authored Dec 9, 2024
1 parent 71f4dc8 commit 772d0d6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,12 @@ const EvaluateSchedule = ({repoAddress, name, onClose, jobName}: Props) => {
</>
);
} else {
return <Button onClick={onClose}>Close</Button>;
return (
<>
<Button intent="primary">Launch all</Button>
<Button onClick={onClose}>Close</Button>
</>
);
}
}, [onClose, shouldEvaluate]);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ const SensorDryRun = ({repoAddress, name, currentCursor, onClose, jobName}: Prop
if (sensorExecutionData || error) {
return (
<Box flex={{direction: 'row', gap: 8}}>
<Button>Launch all</Button>
<Button
data-testid={testId('test-again')}
onClick={() => {
Expand Down

1 comment on commit 772d0d6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-43ahi58x4-elementl.vercel.app

Built with commit 772d0d6.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.