-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reference dagster/max_runtime tag in docs instead of the python const…
…ant (#20243) Summary: Since you might apply this tag in places other than python, the Python constant indirection here is causing more confusion than doing good. Test Plan: Inspect docs page ## Summary & Motivation ## How I Tested These Changes
- Loading branch information
Showing
3 changed files
with
8 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
examples/docs_snippets/docs_snippets/deploying/monitoring_daemon/run_timeouts.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
# start_timeout | ||
from dagster import MAX_RUNTIME_SECONDS_TAG, define_asset_job, job | ||
from dagster import define_asset_job, job | ||
|
||
|
||
@job(tags={MAX_RUNTIME_SECONDS_TAG: 10}) | ||
@job(tags={"dagster/max_runtime": 10}) | ||
def my_job(): | ||
... | ||
|
||
|
||
asset_job = define_asset_job( | ||
name="some_job", selection="*", tags={MAX_RUNTIME_SECONDS_TAG: 10} | ||
name="some_job", selection="*", tags={"dagster/max_runtime": 10} | ||
) | ||
# end_timeout |
2 changes: 1 addition & 1 deletion
2
...ples/docs_snippets/docs_snippets_tests/deploying_tests/test_monitoring_daemon_examples.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7851156
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagster-docs ready!
✅ Preview
https://dagster-docs-mz8zirob4-elementl.vercel.app
https://master.dagster.dagster-docs.io
Built with commit 7851156.
This pull request is being automatically deployed with vercel-action