Skip to content

Commit

Permalink
drop ref to storage kind
Browse files Browse the repository at this point in the history
  • Loading branch information
benpankow committed Aug 23, 2024
1 parent 5cc9a43 commit 78805de
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1215,13 +1215,10 @@ def resolve_tags(self, _graphene_info: ResolveInfo) -> Sequence[GrapheneDefiniti

def resolve_kinds(self, _graphene_info: ResolveInfo) -> Sequence[str]:
if self._external_asset_node.compute_kind:
storage_kind = (self._external_asset_node.tags or {}).get("dagster/storage_kind")
if storage_kind:
return [self._external_asset_node.compute_kind, storage_kind]
return [self._external_asset_node.compute_kind]

return [
key.split("/", maxsplit=2)[-1]
key[len(KIND_PREFIX) :]
for key in (self._external_asset_node.tags or {}).keys()
if get_definition_tag_type(key) == TagType.HIDDEN and key.startswith(KIND_PREFIX)
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2637,7 +2637,7 @@ def test_kinds(self, graphql_context: WorkspaceRequestContext):
)

third_kinds_key = result.data["assetNodeOrError"]
assert set(third_kinds_key["kinds"]) == {"python", "snowflake"}
assert set(third_kinds_key["kinds"]) == {"python"}

result = execute_dagster_graphql(
graphql_context,
Expand Down

0 comments on commit 78805de

Please sign in to comment.