Skip to content

Commit

Permalink
refactor(sling): remove Pattern type hint (#23627)
Browse files Browse the repository at this point in the history
## Summary & Motivation
This is not working in Python 3.8. Fix that by removing the type hint.

## How I Tested These Changes
bk
  • Loading branch information
rexledesma authored and clairelin135 committed Aug 13, 2024
1 parent ff52ccc commit 7aec084
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def _strip_quotes_target_table_name(target_table_name: str) -> str:
return target_table_name.replace('"', "")


INSERT_REGEX: re.Pattern[str] = re.compile(r".*inserted (\d+) rows into (.*) in.*")
INSERT_REGEX = re.compile(r".*inserted (\d+) rows into (.*) in.*")


def _get_target_table_name(stream_name: str, sling_cli: "SlingResource") -> Optional[str]:
Expand Down

1 comment on commit 7aec084

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs ready!

✅ Preview
https://dagster-docs-ivd2cqbu1-elementl.vercel.app
https://release-1-8-1.dagster.dagster-docs.io

Built with commit 7aec084.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.