[Search] Don't show "No results" while search is loading (#23809)

## Summary & Motivation As titled ## How I Tested These Changes If results are loading then don't show the "No results message". ## Changelog [New | Bug | Docs] NOCHANGELOG
dagster-io · Aug 22, 2024 · 7f9d220 · 7f9d220 · github-actions · Aug 22, 2024
1 parent d307d1d
commit 7f9d220
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/search/SearchDialog.tsx b/js_modules/dagster-ui/packages/ui-core/src/search/SearchDialog.tsx
@@ -223,6 +223,7 @@ export const SearchDialog = () => {
             queryString={queryString}
             results={renderedResults}
             onClickResult={onClickResult}
+            searching={loading || state.searching}
           />
         </Container>
       </Overlay>

diff --git a/js_modules/dagster-ui/packages/ui-core/src/search/SearchResults.tsx b/js_modules/dagster-ui/packages/ui-core/src/search/SearchResults.tsx
@@ -232,12 +232,16 @@ export type SearchResultsProps<T extends ResultType> = {
   onClickResult: (result: T) => void;
   queryString: string;
   results: T[];
+  searching: boolean;
 };
 
 export const SearchResults = <T extends ResultType>(props: SearchResultsProps<T>) => {
-  const {highlight, onClickResult, queryString, results} = props;
+  const {highlight, onClickResult, queryString, results, searching} = props;
 
   if (!results.length && queryString) {
+    if (searching) {
+      return;
+    }
     return <NoResults>No results</NoResults>;
   }