-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[dagster-aws] add ECS Task executor (#26098)
## Summary & Motivation This PR ads a new ECS Tasks Executor. Currently a `ECSRunLauncher` is required in order to use the new `ecs_executor` and most of the ECS config comes from the run launcher. The executor can override a few important fields (such as resources and container overrides). Resolve #9671 ## How I Tested These Changes - manual testing in personal AWS account - adding tests with mocks. Heavily using the existing run launcher testing infra since the executor currently requires it anyway ## Changelog [dagster-aws] new `ecs_executor` which executes Dagster steps via AWS ECS tasks. Initially, we expect it to be used in conjunction with `ECSRunLauncher`.
- Loading branch information
1 parent
5499873
commit 82e2189
Showing
11 changed files
with
778 additions
and
43 deletions.
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
python_modules/libraries/dagster-aws/dagster_aws/ecs/__init__.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
from dagster_aws.ecs.executor import ecs_executor as ecs_executor | ||
from dagster_aws.ecs.launcher import EcsRunLauncher as EcsRunLauncher | ||
from dagster_aws.ecs.tasks import EcsEventualConsistencyTimeout as EcsEventualConsistencyTimeout |
Oops, something went wrong.
82e2189
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagster-docs ready!
✅ Preview
https://dagster-docs-q9w0bghxn-elementl.vercel.app
https://master.dagster.dagster-docs.io
Built with commit 82e2189.
This pull request is being automatically deployed with vercel-action
82e2189
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagster-docs-beta ready!
✅ Preview
https://dagster-docs-beta-2syysoxmr-elementl.vercel.app
Built with commit 82e2189.
This pull request is being automatically deployed with vercel-action