[INTERNAL_BRANCH=jamie/bulk-action-filter] fix input types for filter

dagster-io · Aug 22, 2024 · 868bc51 · 868bc51
1 parent 8bbcdfc
commit 868bc51
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 12 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql b/js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql
diff --git a/js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts b/js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts
diff --git a/python_modules/dagster-graphql/dagster_graphql/schema/inputs.py b/python_modules/dagster-graphql/dagster_graphql/schema/inputs.py
@@ -379,9 +379,7 @@ class Meta:
 
 
 class GrapheneBulkActionsFilter(graphene.InputObjectType):
-    status = graphene.List(
-        graphene.NonNull("dagster_graphql.schema.backfill.GrapheneBulkActionStatus")
-    )
+    status = graphene.InputField("dagster_graphql.schema.backfill.GrapheneBulkActionStatus")
     createdBefore = graphene.InputField(graphene.Float)
     createdAfter = graphene.InputField(graphene.Float)
 
@@ -390,11 +388,7 @@ class Meta:
         name = "BulkActionsFilter"
 
     def to_selector(self):
-        if self.status:
-            status = BulkActionStatus.from_graphql_input(self.status)
-        else:
-            status = None
-
+        status = BulkActionStatus[self.status.value] if self.status else None
         created_before = datetime_from_timestamp(self.createdBefore) if self.createdBefore else None
         created_after = datetime_from_timestamp(self.createdAfter) if self.createdAfter else None
 

diff --git a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_asset_backfill.py b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_asset_backfill.py
@@ -1176,7 +1176,6 @@ def test_get_backfills_with_filters():
                 backfill = instance.get_backfill(backfill_id)
                 all_backfills.append(backfill)
 
-            # on PartitionBackfills
             get_backfills_result = execute_dagster_graphql(
                 context,
                 BACKFILLS_WITH_FILTERS_QUERY,
@@ -1200,3 +1199,9 @@ def test_get_backfills_with_filters():
 
             for result in backfill_results:
                 assert result["timestamp"] > all_backfills[3].backfill_timestamp
+
+            get_backfills_result = execute_dagster_graphql(
+                context,
+                BACKFILLS_WITH_FILTERS_QUERY,
+                variables={"filters": {"status": "REQUESTED"}},
+            )