Skip to content

Commit

Permalink
[ui] Make CodeLocationTabs a shared component (#23769)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Plus will have a slightly different set of tabs here. Make it a shared
component.

## How I Tested These Changes

Load internal Storybook with an imported version of the OSS overview
root, verify that it shows the correct Plus tabs.
  • Loading branch information
hellendag authored Aug 21, 2024
1 parent eb005be commit 8f2eeb0
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import {Box} from '@dagster-io/ui-components';
import {CodeLocationTabs} from 'shared/code-location/CodeLocationTabs.oss';

import {CodeLocationDefinitionsMain} from './CodeLocationDefinitionsMain';
import {CodeLocationDefinitionsNav} from './CodeLocationDefinitionsNav';
import {CodeLocationPageHeader} from './CodeLocationPageHeader';
import {CodeLocationTabs} from './CodeLocationTabs';
import {RepoAddress} from '../workspace/types';
import {WorkspaceRepositoryFragment} from '../workspace/types/WorkspaceQueries.types';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ import {
Table,
} from '@dagster-io/ui-components';
import {ComponentProps, ReactNode, useMemo} from 'react';
import {CodeLocationTabs} from 'shared/code-location/CodeLocationTabs.oss';
import {createGlobalStyle} from 'styled-components';
import * as yaml from 'yaml';

import {CodeLocationPageHeader} from './CodeLocationPageHeader';
import {CodeLocationTabs} from './CodeLocationTabs';
import {TimeFromNow} from '../ui/TimeFromNow';
import {LocationStatus} from '../workspace/CodeLocationRowSet';
import {WorkspaceRepositoryLocationNode} from '../workspace/WorkspaceContext';
Expand Down

1 comment on commit 8f2eeb0

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-msi1dfxjn-elementl.vercel.app

Built with commit 8f2eeb0.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.