Skip to content

Commit

Permalink
[DOC-381] make titles optional in CodeExamples (#23938)
Browse files Browse the repository at this point in the history
## Summary

Addresses
https://linear.app/dagster-labs/issue/DOC-381/component-make-titles-optional-in-codeexamples.
This turns out to be very easy, we just don't pass the title to the
underlying component :)



<img width="750" alt="Screenshot 2024-08-26 at 4 29 23 PM"
src="https://github.com/user-attachments/assets/982fc148-1531-4786-b5fd-a386b1d93e03">
  • Loading branch information
benpankow authored Aug 26, 2024
1 parent 5798cb5 commit 9167a21
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/docs-beta/src/components/CodeExample.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const CodeExample: React.FC<CodeExampleProps> = ({filePath, language, title}) =>
}

return (
<CodeBlock language={language} title={title || filePath}>
<CodeBlock language={language} title={title}>
{content || 'Loading...'}
</CodeBlock>
);
Expand Down

2 comments on commit 9167a21

@github-actions
Copy link

@github-actions github-actions bot commented on 9167a21 Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs-beta ready!

✅ Preview
https://dagster-docs-beta-i9ba53u5e-elementl.vercel.app
https://dagster-docs-beta.dagster-docs.io

Built with commit 9167a21.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs ready!

✅ Preview
https://dagster-docs-gjligt05h-elementl.vercel.app
https://master.dagster.dagster-docs.io

Built with commit 9167a21.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.