Skip to content

Commit

Permalink
[7/n] [RFC] Implement updated designs: Initial renames [1/N] (#26105)
Browse files Browse the repository at this point in the history
Linear:
https://linear.app/dagster-labs/issue/FE-697/implement-updated-designs-initial-renames-[1n]

## Summary & Motivation
Everything in Linear ticket

## How I Tested These Changes
tested locally
  • Loading branch information
dliu27 authored Dec 9, 2024
1 parent 3b5ee74 commit 9791ea9
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 38 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
} from '@dagster-io/ui-components';
import {forwardRef, useMemo} from 'react';
import {Link} from 'react-router-dom';
import styled from 'styled-components';

import {AutomationTargetList} from './AutomationTargetList';
import {AutomationRowGrid} from './VirtualizedAutomationRow';
Expand All @@ -25,7 +24,6 @@ import {
ScheduleAssetSelectionQuery,
ScheduleAssetSelectionQueryVariables,
} from '../schedules/types/ScheduleAssetSelectionsQuery.types';
import {EvaluateTickButtonSchedule} from '../ticks/EvaluateTickButtonSchedule';
import {TickStatusTag} from '../ticks/TickStatusTag';
import {RowCell} from '../ui/VirtualizedTable';
import {SINGLE_SCHEDULE_QUERY} from '../workspace/VirtualizedScheduleRow';
Expand Down Expand Up @@ -164,13 +162,6 @@ export const VirtualizedAutomationScheduleRow = forwardRef(
<MiddleTruncate text={name} />
</Link>
</Box>
<EvaluateTickButtonScheduleWrapper>
<EvaluateTickButtonSchedule
name={scheduleData?.name || ''}
repoAddress={repoAddress}
jobName={scheduleData?.pipelineName || ''}
/>
</EvaluateTickButtonScheduleWrapper>
</Box>
</RowCell>
<RowCell>
Expand Down Expand Up @@ -242,9 +233,3 @@ export const VirtualizedAutomationScheduleRow = forwardRef(
);
},
);

const EvaluateTickButtonScheduleWrapper = styled.div`
button {
height: 24px;
}
`;
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
} from '@dagster-io/ui-components';
import {forwardRef, useMemo} from 'react';
import {Link} from 'react-router-dom';
import styled from 'styled-components';

import {AutomationTargetList} from './AutomationTargetList';
import {AutomationRowGrid} from './VirtualizedAutomationRow';
Expand All @@ -22,7 +21,6 @@ import {
SensorAssetSelectionQuery,
SensorAssetSelectionQueryVariables,
} from '../sensors/types/SensorRoot.types';
import {EvaluateTickButtonSensor} from '../ticks/EvaluateTickButtonSensor';
import {TickStatusTag} from '../ticks/TickStatusTag';
import {RowCell} from '../ui/VirtualizedTable';
import {SENSOR_TYPE_META, SINGLE_SENSOR_QUERY} from '../workspace/VirtualizedSensorRow';
Expand Down Expand Up @@ -163,19 +161,6 @@ export const VirtualizedAutomationSensorRow = forwardRef(
<MiddleTruncate text={name} />
</Link>
</Box>
{sensorData ? (
<EvaluateTickButtonSensorWrapper>
<EvaluateTickButtonSensor
cursor={cursor || ''}
name={sensorData?.name || ''}
repoAddress={repoAddress}
jobName={sensorData?.targets?.[0]?.pipelineName || ''}
sensorType={sensorData.sensorType}
/>
</EvaluateTickButtonSensorWrapper>
) : (
<div style={{width: 30}} />
)}
</Box>
</RowCell>
<RowCell>
Expand Down Expand Up @@ -235,9 +220,3 @@ export const VirtualizedAutomationSensorRow = forwardRef(
);
},
);

const EvaluateTickButtonSensorWrapper = styled.div`
button {
height: 24px;
}
`;
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const EvaluateTickButtonSchedule = ({
setShowTestTickDialog(true);
}}
>
Evaluate tick
Preview tick result
</Button>
<EvaluateScheduleDialog
isOpen={showTestTickDialog}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const EvaluateTickButtonSensor = ({
disabled={sensorType !== SensorType.STANDARD}
onClick={() => setShowTestTickDialog(true)}
>
Evaluate tick
Preview tick result
</Button>
</Tooltip>
<SensorDryRunDialog
Expand Down

0 comments on commit 9791ea9

Please sign in to comment.