-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Sensor history: Fix tick ID variable (#23802)
## Summary & Motivation There is a bug on the sensor tick table where clicking to view a run requested for a tick can show information about an unrelated tick. This is because sensor tick IDs can be larger than JavaScript's `Number.MAX_SAFE_INTEGER`, but they're being cast to `Number` for the GraphQL variable. JS may cast the value to a number that doesn't match the intended value, resulting in the wrong tick ID being sent in the query. We shouldn't be trying to represent them as `number` in JS. The GraphQL input type expects it to be a BigInt, and we can just pass a string for that. ## How I Tested These Changes View sensor tick history with ticks that have tick IDs being cast to incorrect values. Verify that the values are now correct, and that when I click to view runs requested for the tick, the query variable and rendered output are correct.
- Loading branch information
Showing
3 changed files
with
7 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e2898c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-6ja9bo9uh-elementl.vercel.app
Built with commit 9e2898c.
This pull request is being automatically deployed with vercel-action