Skip to content

Commit

Permalink
[test-all] pin pendulum back to version 2 on python 3.8 (#19501)
Browse files Browse the repository at this point in the history
Summary:
[test-all]
pendulum 3 is causing mysterious SIGABRTS on python 3.8, and only python
3.8, in our CI/CD. Eliminate that version from the pin removal for now,
since the primary goal of pendulum 3 is to unlock python 3.12 support
anyways.

Test Plan:

## Summary & Motivation

## How I Tested These Changes
  • Loading branch information
gibsondan authored and OwenKephart committed Jan 31, 2024
1 parent 707382e commit 9ecfb73
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,11 @@ def k8s_extra_cmds(version: str, _) -> List[str]:
"cli_tests", # test suite prone to hangs on unpinned grpcio version due to https://github.com/grpc/grpc/issues/31885
}
)
else []
else (
[AvailablePythonVersion.V3_8] # pendulum 3 not supported on python 3.8
if tox_factor in {"scheduler_tests", "definitions_tests"}
else []
)
)
),
),
Expand Down
3 changes: 2 additions & 1 deletion python_modules/dagster/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ def get_version() -> str:
f"grpcio>={GRPC_VERSION_FLOOR}",
f"grpcio-health-checking>={GRPC_VERSION_FLOOR}",
"packaging>=20.9",
"pendulum>=0.7.0,<4",
"pendulum>=0.7.0,<4; python_version>='3.9'",
"pendulum>=0.7.0,<3; python_version<'3.9'", # https://github.com/dagster-io/dagster/issues/19500
"protobuf>=3.20.0,<5", # min protobuf version to be compatible with both protobuf 3 and 4
"python-dateutil",
"python-dotenv",
Expand Down

0 comments on commit 9ecfb73

Please sign in to comment.